Add frames accept null #1254
Merged
Add frames accept null #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Dec 14, 2016
| @@ -43,6 +43,13 @@ describe('Test frame api', function() { | |||
| }).catch(fail).then(done); | |||
| }); | |||
|
|
|||
| it('compresses nulls when adding frames', function(done) { | |||
There was a problem hiding this comment.
not just nulls to be fair. but yeah this seems like the correct behavoir
|
💃 |
|
Expecting passed tests; waiting for confirmation just to play it safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @bpostlethwaite
I've added the capability to ignore null frames in
addFrames. I think it's good, but honestly I find the index-based addFrames a bit fragile and undesirable in the first place, so I hate to push 'fixes' through too quickly. All it does is continue to the next frame if the input is null.